Proposed fix for 856 Recursive VST Effect Enhancement Request #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if(dirs.at( i )[0] != '.' ) | ||
| { | ||
| addPluginsFromDir( filenames, path+QDir::separator() + dirs.at( i ) ); |
|
Looks great. Some minor formatting changes and this should be good to go (@lukas-w wants those extra spaces removed from our coding spec, but until that happens... 😕 ) I noticed the name now reflects the relative path. That may cause some overflowing text issues on the longer path names, but that's easy enough to change in the 1.2 testing phases.
|
done. |
tresf
added a commit
that referenced
this pull request
Dec 22, 2014
Proposed fix for 856 Recursive VST Effect Enhancement Request
They do look nice, but are so easy to miss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #856 Recursive VST Effect Enhancement Request