Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative splash screen status message implementation #1982

Closed
wants to merge 2 commits into from

Conversation

Wallacoloo
Copy link
Member

This is an alternative implementation of #1915 that avoids using signals/slots or deriving from QObject.

It implements a new Messenger class that might be useful in removing core -> gui dependencies elsewhere too.

@curlymorphic
Copy link
Contributor

This all works :)
@Wallacoloo thanks for this.

might be useful in removing core -> gui dependencies elsewhere too.

Justs a side note, I know there are future plans for RT-safety in the audio core. So this message system may not be suitable for use inside the audio processing code. I feel It is totally fine for it's current use :).

@tresf
Copy link
Member

tresf commented Apr 20, 2015

I really like this. We should get review by a few more core developers prior to merging. @lukas-w @diizy

@lukas-w
Copy link
Member

lukas-w commented Apr 25, 2015

While a message system like this is cool, it's overkill for just the splash screen. Also, Qt already provides a good debugging/logging system. See Qt's Debugging Techniques.
I think there's no need to bloat our code with this, so I'd strongly favor #1915.

@Wallacoloo
Copy link
Member Author

@lukas-w thanks for taking the time to review this.

@Wallacoloo
Copy link
Member Author

Closing, as this doesn't seem to be a preferred alternative & Lukas raised a good point about bloat.

@Wallacoloo Wallacoloo closed this Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants