Fix build problems with gcc 5.2 in Debian. #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler complain about static inline functions being used from inline functions. This patch rewrite the inline to static inline functions to avoid the compiler error. This is related to https://bugs.debian.org/777989 and based on a patch in the Debian packaging, see http://anonscm.debian.org/cgit/debian-edu/pkg-team/lmms.git/tree/debian/patches .
Wallacoloo
added a commit
that referenced
this pull request
Sep 20, 2015
Fix build problems with gcc 5.2 in Debian.
|
Although this seems trivial, we need to submit these upstream too. Upstream uses a code generator (XML if I recall correctly), so the upstream patch will look slightly different however Steve Harris is very responsive on that repo and patches generally get accepted within a week or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler complain about static inline functions being used from
inline functions. This patch rewrite the inline to static inline
functions to avoid the compiler complaining.
This is related to https://bugs.debian.org/777989 and based on a patch
in the Debian packaging, see
http://anonscm.debian.org/cgit/debian-edu/pkg-team/lmms.git/tree/debian/patches .