Pass build flags to wineg++ #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,9 @@ OPTION(WANT_WINMM "Include WinMM MIDI support" OFF) | |||
| OPTION(WANT_QT5 "Build with Qt5" OFF) | |||
|
|
|||
|
|
|||
| SET(WINE_CXX_FLAGS "" CACHE STRING "Extra flags passed to wineg++") | |||
There was a problem hiding this comment.
@jasp00 wouldn't this make more functional sense in the IF(WANT_VST) block, since we don't use Wine for anything else?
There was a problem hiding this comment.
This is a configuration variable, like WANT_VST_NOWINE; it could be configured with cmake-gui. I see that conditional variables appear after configuring; perhaps this variable should be moved to plugins/vst_base/CMakeLists.txt.
|
Changed. |
|
Conflict resolved. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Pass build flags to wineg++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of RemoteVstPlugin did not use flags from normal builds, such as debugging information and some warnings. Omitting the frame pointer in optimization does not work.
WINE_CXX_FLAGSallows packagers to set extra flags, such as RUNPATH information.