Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document identifier collision in peak_controller_effect_controls.cpp #3444

Merged
merged 1 commit into from May 3, 2017

Conversation

jasp00
Copy link
Member

@jasp00 jasp00 commented Mar 20, 2017

Flag the issue. Keep this open until someones fixes it. This may be merged.

@Umcaruje Umcaruje changed the base branch from master to stable-1.2 March 26, 2017 11:33
@jasp00 jasp00 changed the title Fix identifier collision in peak_controller_effect_controls.cpp Document identifier collision in peak_controller_effect_controls.cpp Apr 2, 2017
@tresf tresf changed the base branch from stable-1.2 to master May 3, 2017 02:18
@tresf
Copy link
Member

tresf commented May 3, 2017

Merging.

For future reference, small commits and tiny comments/edits from project members can be committed directly to the repo without a PR. Rebasing against master as this has no code benefit in the stable-1.2 branch.

@tresf tresf merged commit 0942586 into master May 3, 2017
@lukas-w lukas-w deleted the jasp00-patch-3 branch May 7, 2018 17:14
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Document identifier collision in peak_controller_effect_controls.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants