New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically change pattern lengths after shifting note positions(Fixes #3563) #3567

Merged
merged 1 commit into from May 21, 2017

Conversation

Projects
None yet
3 participants
@PhysSong
Member

PhysSong commented May 21, 2017

Fixes #3563.
Added m_pattern->updateLength(); in PianoRoll::shiftPos().
I think it is also needed for master branch.

Fixes #3563
Added m_pattern->updateLength(); in PianoRoll::shiftPos

@BaraMGB BaraMGB merged commit f8a508f into LMMS:stable-1.2 May 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong May 21, 2017

Member

Could anyone merge this commit into master branch?

Member

PhysSong commented May 21, 2017

Could anyone merge this commit into master branch?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 22, 2017

Member
Member

Umcaruje commented May 22, 2017

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong May 22, 2017

Member

@Umcaruje OK, thanks.

Member

PhysSong commented May 22, 2017

@Umcaruje OK, thanks.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fixes #3563 (#3567)
Added m_pattern->updateLength(); in PianoRoll::shiftPos

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fixes #3563 (#3567)
Added m_pattern->updateLength(); in PianoRoll::shiftPos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment