Use Canonical Paths for Relative Paths Calculations #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhysSong
reviewed
Mar 4, 2018
tests/src/core/RelativePathsTest.cpp
Outdated
| @@ -40,8 +40,10 @@ private slots: | |||
|
|
|||
| QString absPath = fi.absoluteFilePath(); | |||
| QString relPath = "drums/kick01.ogg"; | |||
| QString fuzPath = absPath.replace(relPath, "drums/.///kick01.ogg"); | |||
There was a problem hiding this comment.
Current one won't work because this line modifies absPath. This one will work:
QString fuzPath = absPath;
fuzPath.replace(relPath, "drums/.///kick01.ogg");There was a problem hiding this comment.
Ah yes, forgot Strings are mutable in Qt. Thanks.
QString are mutable objects. Call replace on the clone, not on the original.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Fix redundant path elements Closes LMMS#4173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces strange paths like
/path/.///to/../from/foo/////to be/path/from/foo.Closes #4173