Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master cleanup #4431

Merged
merged 2 commits into from Jun 17, 2018
Merged

Master cleanup #4431

merged 2 commits into from Jun 17, 2018

Conversation

dobbelaj
Copy link
Contributor

Introduce and use UI_CTRL_KEY as abstraction for the "Ctrl" (and equivalent) key on different OS.

This is an abstraction for the name of the 'Ctrl' (or equivalent) key on
linux, windows and apple systems.
Copy link
Member

@lukas-w lukas-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to clean this up! 👍 I'm not sure about the defines being in lmms_basics.h because it only contains non-UI code, but I don't really know a better place to put it so I guess it's fine for now.

@lukas-w lukas-w merged commit d11966a into LMMS:master Jun 17, 2018
@dobbelaj
Copy link
Contributor Author

Once we have a better place, we can move the define there. Thanks for the review and approval !

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
This is an abstraction for the name of the 'Ctrl' (or equivalent) key on
linux, windows and apple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants