New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake/install refactor #5142
Cmake/install refactor #5142
Conversation
c73bb17
to
e32de9f
Compare
ExternalProject_Get_Property(${name} BINARY_DIR) | ||
|
||
install(CODE | ||
"execute_process(COMMAND ${CMAKE_COMMAND} \"-DCMAKE_INSTALL_PREFIX=\${CMAKE_INSTALL_PREFIX}\" -P cmake_install.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the CMake documentation, it seems like we should pass COMPONENT
and BUILD_TYPE
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to have a syntax problem. I don't know why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we can just include the target's cmake_install.cmake
as well.
@Reflexe Is it okay for you if I add some commits here? |
of course. |
Currently we have two problems (apart from THE problem with the file generation).
|
I'm working on those issues and made some progress. I will try to finish that tomorrow. |
Replaces the hard-coded library paths by a method based on CMake's GetPrerequisites module which recursively finds a binary file's linked libraries. Advantage: Potentially works on any system without adaption as long as CMake supports it, so it could be used to create portable Linux packages as well. Disadvantage: "Potentially". Co-Authored-By: Hyunjin Song <tteu.ingog@gmail.com>
I rebased commits a bit, and fixed remaining issues. You can find the commits in https://github.com/PhysSong/lmms/commits/cmake/install-refactor. @Reflexe Is it okay for you if I force-push here? |
did that already. |
7e6b422
to
8897838
Compare
I can probably add minor changes here for concreteness. After testing them out, we can hopefully merge this one. |
8897838
to
8711e77
Compare
just force-pushed a fix for an embarrassing spelling mistake :D |
Can we merge this? |
@Reflexe I forgot to ask your opinion on #5142 (comment). Also, it seems like we don't need to pass |
Co-Authored-By: Hyunjin Song <tteu.ingog@gmail.com>
* Install UCRT libraries * Install debug libraries in debug builds
8711e77
to
94354e3
Compare
Support automatic dll collection and refactor cmake installation process.
No description provided.