Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the context menu actions when multiple TCOs are selected #5601

Merged
merged 22 commits into from Aug 10, 2020
Merged

Improve the context menu actions when multiple TCOs are selected #5601

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fab8cf6
Starts implementing the feature
IanCaio Jul 29, 2020
865172b
Allows selected TCOs to be removed too
IanCaio Jul 29, 2020
182fa10
Starts implementing selected TCO cut and copy
IanCaio Jul 29, 2020
52f8f9d
Merge branch 'master' into feature/selectedTCOActions
IanCaio Jul 30, 2020
0e40683
Overloads TCW paste selection methods
IanCaio Jul 31, 2020
c14e6ad
Adds the TCO type to the clipboard
IanCaio Jul 31, 2020
09d7298
Apply changes to "src/tracks/SampleTrack.cpp"
IanCaio Jul 31, 2020
c0688c3
Implement the paste action
IanCaio Jul 31, 2020
5c0d6de
Removes QDebug header
IanCaio Jul 31, 2020
76df232
Creates a Context Menu on the TCW for "paste"
IanCaio Jul 31, 2020
f8cb3f5
Small code refactoring
IanCaio Jul 31, 2020
2cf3f71
Avoids double call to canPasteSelection
IanCaio Aug 1, 2020
28e2a18
Separates methods for the actions on selections
IanCaio Aug 1, 2020
33516ec
Fixes small bug and reorganize code
IanCaio Aug 2, 2020
511a2db
Move logic to the action methods
IanCaio Aug 2, 2020
716fe02
Changes logic structure and labels
IanCaio Aug 2, 2020
24beb4d
Make removeActive and toggleMuteActive static
IanCaio Aug 2, 2020
82deaa2
Renamed TCO View paste method
IanCaio Aug 2, 2020
c307bbc
Merge branch 'master' into feature/selectedTCOActions
IanCaio Aug 7, 2020
3478638
Moves repeated code to a new method
IanCaio Aug 7, 2020
8fcb0b0
Avoid unnecessary calls to getClickedTCOs()
IanCaio Aug 8, 2020
8f1d874
Fix indenting in a ternary operator assignment
IanCaio Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 10 additions & 6 deletions include/Track.h
View file
Open in desktop
Expand Up @@ -250,12 +250,16 @@ class TrackContentObjectView : public selectableObject, public ModelView
bool needsUpdate();
void setNeedsUpdate( bool b );

// Methods to remove, copy, cut, paste and mute selections of TCO views
void removeSelection( QVector<selectableObject *> so );
void copySelection( QVector<selectableObject *> so );
void cutSelection( QVector<selectableObject *> so );
void pasteSelection(); // TODO: Rethink naming?
void toggleMuteSelection( QVector<selectableObject *> so );
// Methods to remove, copy, cut, paste and mute a QVector of TCO views
IanCaio marked this conversation as resolved.
Show resolved Hide resolved
void copyActive( QVector<TrackContentObjectView *> tcovs );
void cutActive( QVector<TrackContentObjectView *> tcovs );
void paste();
// removeActive and toggleMuteActive are static because they don't depend
// being called from a particular TCO view, but can be called anywhere as long
// as a valid TCO view list is given, while copy/cut require an instance for
// some metadata to be written to the clipboard.
static void removeActive( QVector<TrackContentObjectView *> tcovs );
static void toggleMuteActive( QVector<TrackContentObjectView *> tcovs );

public slots:
virtual bool close();
Expand Down