sort items in tree-browsers caseinsensitively in alphabetical order #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12024-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.63%2Bg218d93b-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12024?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12022-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.63%2Bg218d93bae-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12022?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12021-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.63%2Bg218d93bae-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12021?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/iwtn3sxej0niww5b/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37143547"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/799uusr4thpqg0cr/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37143547"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12023-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.63%2Bg218d93bae-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12023?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "21542189d0ed062ccf39a3c2c7580297868c9d54"} |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tresf
reviewed
Jan 5, 2021
This comment has been minimized.
This comment has been minimized.
…resented to the user
tresf
reviewed
Jan 6, 2021
tresf
reviewed
Jan 6, 2021
|
Thanks! Just some whitespace formatting (hope you don't mind) and we'll merge! |
Spekular
reviewed
Jan 7, 2021
|
Counting tresf's earlier comment as approval and adding my own => 2 approvals, merging. CI passed for previous commit (ignoring unrelated errors) and the only change since is an empty line.
|
zynskeywolf
pushed a commit
to zynskeywolf/lmms
that referenced
this pull request
Jan 12, 2021
* sort items in tree-browsers caseinsensitively in alphabetical order
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
* sort items in tree-browsers caseinsensitively in alphabetical order
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
* sort items in tree-browsers caseinsensitively in alphabetical order
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* sort items in tree-browsers caseinsensitively in alphabetical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the item order alphabetically independent from naming style. Hence items will be sorted with the following manner:
Affects amongst others Instrument Plugins, My Projects, My Samples, My Presets, My Home, Root Directory and their sub items. See the issue for details