Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign file browser searching #7130

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Redesign file browser searching #7130

wants to merge 30 commits into from

Commits on Feb 26, 2024

  1. Add ThreadPoolTest

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a5a8e47 View commit details
    Browse the repository at this point in the history

  2. Implement construction and deconstruction functionality

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9b56f28 View commit details
    Browse the repository at this point in the history

  3. Add processing functionality

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5190984 View commit details
    Browse the repository at this point in the history

  4. Add FileSearch interface

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    767053c View commit details
    Browse the repository at this point in the history

  5. Specify type of numWorkers as size_t

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8671c07 View commit details
    Browse the repository at this point in the history

  6. Add MinGW headers for future and thread

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    773484c View commit details
    Browse the repository at this point in the history

  7. Add header guard in FileSearch.h

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ccf460e View commit details
    Browse the repository at this point in the history

  8. Add FileSearch implementation

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f3bd008 View commit details
    Browse the repository at this point in the history

  9. Add the global ThreadPool instance

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f2645a2 View commit details
    Browse the repository at this point in the history

  10. Fix deadlock in ThreadPool::run

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7abf2bc View commit details
    Browse the repository at this point in the history

  11. Integrate new functionality into FileBrowser

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c5f362e View commit details
    Browse the repository at this point in the history

  12. Add test for processing multiple tasks

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c3f28ec View commit details
    Browse the repository at this point in the history

  13. Add 1 millisecond delay to tests

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    62a3c05 View commit details
    Browse the repository at this point in the history

  14. Increase NumWorkers from 1 to 2

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    39db31c View commit details
    Browse the repository at this point in the history

  15. Remove old implementation

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9381cf2 View commit details
    Browse the repository at this point in the history

  16. Blacklist sub entries in FileBrowser

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    e9e316f View commit details
    Browse the repository at this point in the history

  17. Remove qnamespace.h header

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b810fe3 View commit details
    Browse the repository at this point in the history

  18. Include memory header

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3acb0aa View commit details
    Browse the repository at this point in the history

  19. Attempt to fix MinGW builds

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6e6d824 View commit details
    Browse the repository at this point in the history

  20. Remove ThreadPoolTest because of MinGW

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1d1fe1f View commit details
    Browse the repository at this point in the history

  21. Remove atomic header

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fc02a57 View commit details
    Browse the repository at this point in the history

  22. Use MinGW headers

    @sakertooth
    sakertooth committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    864be75 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Remove use of std::packaged_task by using std::promise directly

    @sakertooth
    sakertooth committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ab976d5 View commit details
    Browse the repository at this point in the history

  2. Remove init function

    @sakertooth
    sakertooth committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e7b76e7 View commit details
    Browse the repository at this point in the history

  3. Pass task into work queue directly

    @sakertooth
    sakertooth committed May 9, 2024
    Configuration menu
    Copy the full SHA
    96ee773 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Simply cancel the search without manually resetting it 

    The search will get destroyed when replacing it with the new one through the assignment
    @sakertooth
    sakertooth committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1d9b3f8 View commit details
    Browse the repository at this point in the history

  2. Recursively search for directories, regardless if they match the filt… 

    …ers or not

So the search was broken and missing entries because
the code was not searching through the directories that *did* match the filters. This is also why the search
was oddly fast and completed very quickly.
    @sakertooth
    sakertooth committed May 10, 2024
    Configuration menu
    Copy the full SHA
    62b58a6 View commit details
    Browse the repository at this point in the history

  3. Use std::for_each with reverse iterators

    @sakertooth
    sakertooth committed May 10, 2024
    Configuration menu
    Copy the full SHA
    70522bd View commit details
    Browse the repository at this point in the history

  4. Replace use of the word blacklist with exclude

    @sakertooth
    sakertooth committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7f4ca20 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge remote-tracking branch 'upstream/master' into redesign-file-bro… 

    …wser-search
    @sakertooth
    sakertooth committed May 17, 2024
    Configuration menu
    Copy the full SHA
    88724e2 View commit details
    Browse the repository at this point in the history