Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSVC support for GigPlayer (rework) #7162

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add MSVC support for GigPlayer (rework) #7162

wants to merge 9 commits into from

Commits on Mar 30, 2024

  1. Add MSVC support for GigPlayer

    @Veratil
    Veratil committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    397685f View commit details
    Browse the repository at this point in the history

  2. !fixup bump size of buffers up

    @Veratil
    Veratil committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    fa14019 View commit details
    Browse the repository at this point in the history

  3. !fixup did not bump size check to 1024

    @Veratil
    Veratil committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    529c249 View commit details
    Browse the repository at this point in the history

  4. !fixup Dom's CMake review

    @Veratil
    Veratil committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    b6c78d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. GigPlayer refactoring 

    * GigInstrument::play
* GigInstrument::loadSample
* GigInstrument::getLoopedIndex
* GigInstrument::getPingPongIndex
Use proper sized types, std::list instead of QList, STL loops
VLAs converted to std::array are now std::vector instead, resizing only when needed capacity is greater than the current
    @Veratil
    Veratil committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1f37374 View commit details
    Browse the repository at this point in the history

  2. Add missing header

    @Veratil
    Veratil committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b66740c View commit details
    Browse the repository at this point in the history

  3. Use std::for_each_n on supported versions, fall back to normal for lo… 

    …op otherwise
    @Veratil
    Veratil committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bc71903 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Test gig version defines and defining file_offset_t manually if versi… 

    …on is older than where it's defined
    @Veratil
    Veratil committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    16d26a5 View commit details
    Browse the repository at this point in the history

  2. !fixup maybe adding quotes around variable will let msvc build pass a… 

    …t least?
    @Veratil
    Veratil committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2d35a86 View commit details
    Browse the repository at this point in the history