Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wine include detection for Wine > 9.0 #7260

Closed
wants to merge 3 commits into from

Conversation

Rossmaxx
Copy link
Contributor

@Rossmaxx Rossmaxx commented May 16, 2024

Fixes the issue where building lmms with wine > 9.0 doesn't build remotevstplugin. Thanks @LostRobotMusic for suggesting the change (He actually suggested to fix CmakeCache.txt and I used it as a clue for this fix)

Fixes : #7169

Requesting @PhysSong and @DomClark for reviews.

cmake/modules/FindWine.cmake Outdated Show resolved Hide resolved
@tresf
Copy link
Member

tresf commented May 16, 2024

Fixes the issue where building lmms with wine > 9.0 doesn't build remotevstplugin. Thanks @LostRobotMusic for suggesting the change (He actually suggested to fix CmakeCache.txt and I used it as a clue for this fix)

Fixes : #7169

TODO : Remove old VST include finding code using the macro and replace it fully with paths. Also remove redundant paths. also look into the appimage vst bundling issues.

I feel strongly that hard-coding isn't the way forward here. Diving into the output of ${WINE_CXX} -m32 -v and friends and determining the difference in newer Wine versions is likely the way forward.

@Rossmaxx
Copy link
Contributor Author

I have decided to keep this PR short so as to just fix the missing includes issue. I'll deal with the appimage issue in the future.

@tresf

This comment was marked as outdated.

@tresf

This comment was marked as outdated.

@tresf tresf mentioned this pull request May 19, 2024
2 tasks
@tresf
Copy link
Member

tresf commented May 19, 2024

I've opened a new PR #7268 which adds -- what I believe to be -- some improvements to FindWine. Unfortunately I'm hitting some roadblocks over there. Help is appreciated.

@Rossmaxx
Copy link
Contributor Author

Closing in favour of #7268

@Rossmaxx Rossmaxx closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VST's Not Loading
2 participants