Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Werror=self-move in test for GCC >= 13 #7288

Merged

Conversation

FyiurAmron
Copy link
Contributor

@FyiurAmron
Copy link
Contributor Author

@messmerd many thanks, BTW can you approve the workflow in this PR as well?

@messmerd messmerd merged commit d1a15e5 into LMMS:master May 28, 2024
8 of 9 checks passed
@FyiurAmron
Copy link
Contributor Author

@messmerd many thanks! One last thing here: I noticed the macos check failed

[18/21] Unmounting temporary image... [FAIL]
[19/21] Removing temporary image... [ OK ]
[20/21] Removing target image... [ OK ]

Error: Command failed: hdiutil detach /Volumes/LMMS 1.3.0-alpha.1.616+pr72
hdiutil: detach failed - No such file or directory

, but I don't see any connection to this change, and the build for Mac seemingly succeeded. What's going on? It looks like a fluke, but still better safe than sorry :}

@messmerd
Copy link
Member

@FyiurAmron The macOS builds do that sometimes though I'm not sure why. Re-running the build fixes it.

@FyiurAmron FyiurAmron deleted the disable-warning-for-self-move-on-gcc-13 branch May 29, 2024 10:50
FyiurAmron added a commit to FyiurAmron/lmms that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants