Skip to content

Commit

Permalink
use keepalive on CLI (#629)
Browse files Browse the repository at this point in the history
Instead of the more aggressive closing of all sockets when a peer disconnects, use TCP keepalive on cli sockets. The reason is that multiple instances of an application can share the same target IP address and we don't want to aggressively force close all CLI active socket just because a single instance failed
  • Loading branch information
philippe44 committed Jun 30, 2021
1 parent 3d5fa12 commit 715f435
Show file tree
Hide file tree
Showing 2 changed files with 104 additions and 122 deletions.
3 changes: 0 additions & 3 deletions Slim/Networking/Slimproto.pm
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,6 @@ sub slimproto_close {
Slim::Networking::Select::removeWrite($clientsock);
Slim::Networking::Select::removeWriteNoBlockQ($clientsock);

# close any associated cli_socket
Slim::Plugin::CLI::Plugin::client_socket_cleanup($clientsock->peerhost);

# close socket
$clientsock->close();

Expand Down

0 comments on commit 715f435

Please sign in to comment.