Fix a big bunch of undefined variable access warnings

Slim/Buttons/XMLBrowser.pm

@@ -537,6 +537,7 @@ sub gotOPML {
 		# keep track of station icons
 		if ( 
 			( $item->{play} || $item->{playlist} || ($item->{type} && ($item->{type} eq 'audio' || $item->{type} eq 'playlist')) )
+			&& $item->{url} && !ref $item->{url}
 			&& $item->{url} =~ /^http/ 
 			&& $item->{url} !~ m|\.com/api/\w+/v1/opml| 
 			&& ( my $cover = $item->{image} || $item->{cover} )

Slim/Control/Commands.pm

@@ -1054,9 +1054,9 @@ sub playlistJumpCommand {
 
 	# if we're jumping +1/-1 in the index let squeezeplay know this showBriefly is to be styled accordingly
 	my $jiveIconStyle = undef;
-	if ($index eq '-1') {
+	if ($index && $index eq '-1') {
 		$jiveIconStyle = 'rew';
-	} elsif ($index eq '+1')  {
+	} elsif ($index && $index eq '+1')  {
 		$jiveIconStyle = 'fwd';
 	}
 	$showStatus->($jiveIconStyle);

Slim/Control/Stdio.pm

@@ -60,7 +60,7 @@ sub processRequest {
 
 		main::INFOLOG && $log->info("Got line: $firstline");
 
-		my $message = executeCmd($firstline);
+		my $message = executeCmd($firstline) || '';
 
 		main::INFOLOG && $log->info("Response is: $message");
 

Slim/Control/XMLBrowser.pm

@@ -1028,6 +1028,7 @@ sub _cliQuery_done {
 					# keep track of station icons
 					if ( 
 						$isPlayable 
+						&& $item->{url} && !ref $item->{url}
 						&& $item->{url} =~ /^http/ 
 						&& $item->{url} !~ m|\.com/api/\w+/v1/opml| 
 						&& (my $cover = ($item->{image} || $item->{cover})) 

Slim/Formats/XML.pm

@@ -39,7 +39,7 @@ sub _cacheKey {
 	my $cachekey = $url;
 
 	if ($client) {
-		$cachekey .= '-' . $client->languageOverride;
+		$cachekey .= '-' . ($client->languageOverride || '');
 	}
 
 	return $cachekey . '_parsedXML';

Slim/Menu/AlbumInfo.pm

@@ -510,7 +510,7 @@ sub cliQuery {
 	my $menuMode       = $request->getParam('menu') || 0;
 	my $menuContext    = $request->getParam('context') || 'normal';
 	my $playlist_index = defined( $request->getParam('playlist_index') ) ?  $request->getParam('playlist_index') : undef;
-	my $connectionId   = $request->connectionID;
+	my $connectionId   = $request->connectionID || '';
 
 	my %filter;
 	foreach (qw(artist_id genre_id year library_id)) {

Slim/Menu/ArtistInfo.pm

@@ -295,7 +295,7 @@ sub cliQuery {
 	my $menuMode       = $request->getParam('menu') || 0;
 	my $menuContext    = $request->getParam('context') || 'normal';
 	my $playlist_index = defined( $request->getParam('playlist_index') ) ?  $request->getParam('playlist_index') : undef;
-	my $connectionId   = $request->connectionID;
+	my $connectionId   = $request->connectionID || '';
 
 	my $tags = {
 		menuMode      => $menuMode,

Slim/Menu/BrowseLibrary.pm

@@ -822,7 +822,7 @@ sub _generic {
 	# remote_library might be part of the @searchTags. But it's to be consumed by
 	# BrowseLibrary, rather than by the CLI.
 	if (!$args->{remote_library}) {
-		($args->{remote_library}) = map { /remote_library:(.*)/ && $1 } grep /remote_library/, @$queryTags;
+		($args->{remote_library}) = map { /remote_library:(.*)/ && $1 } grep { $_ && /remote_library/ } @$queryTags;
 	}
 
 	# library_id:-1 is supposed to clear/override the global library_id

Slim/Menu/FolderInfo.pm

@@ -168,7 +168,7 @@ sub cliQuery {
 	my $client    = $request->client;
 	my $folder_id = $request->getParam('folder_id');
 	my $menuMode  = $request->getParam('menu') || 0;
-	my $connectionId = $request->connectionID;
+	my $connectionId = $request->connectionID || '';
 
 	unless ( $folder_id || $cachedFeed{$connectionId} ) {
 		$request->setStatusBadParams();

Slim/Networking/SimpleAsyncHTTP.pm

@@ -370,7 +370,7 @@ sub _cacheKey {
 	my $cachekey = $url;
 
 	if ($client) {
-		$cachekey .= '-' . $client->languageOverride;
+		$cachekey .= '-' . ($client->languageOverride || '');
 	}
 
 	return $cachekey;

Slim/Player/Protocols/Volatile.pm

@@ -12,6 +12,7 @@ use strict;
 
 use Slim::Music::Artwork;
 use Slim::Utils::Log;
+use Slim::Utils::Strings qw(cstring);
 use base qw(Slim::Player::Protocols::File);
 
 sub isRemote { 1 }
@@ -35,7 +36,7 @@ sub getMetadataFor {
 		my $attributes = Slim::Formats->readTags( $path );
 
 		# make sure we have a value for artist, or we'll end up scanning the file over and over again
-		$attributes->{ARTIST} = $client->string('NO_ARTIST') unless defined $attributes->{ARTIST};
+		$attributes->{ARTIST} = cstring($client, 'NO_ARTIST') unless defined $attributes->{ARTIST};
 
 		$track->setAttributes($attributes) if $attributes && keys %$attributes;
 

Slim/Plugin/Deezer/ProtocolHandler.pm

@@ -576,7 +576,7 @@ sub getMetadataFor {
 		my $song = $client->currentSongForUrl($url);
 		if (!$song || !($url = $song->pluginData('radioTrackURL'))) {
 			return {
-				title     => $url =~ /flow\.dzr/ ? $client->string('PLUGIN_DEEZER_FLOW') : $client->string('PLUGIN_DEEZER_SMART_RADIO'),
+				title     => ($url && $url =~ /flow\.dzr/) ? $client->string('PLUGIN_DEEZER_FLOW') : $client->string('PLUGIN_DEEZER_SMART_RADIO'),
 				bitrate   => '320k CBR',
 				type      => 'MP3 (Deezer)',
 				icon      => $icon,

Slim/Plugin/ExtendedBrowseModes/Plugin.pm

@@ -523,7 +523,7 @@ sub _hitlist { if (main::STATISTICS) {
 	Slim::Menu::BrowseLibrary::_tracks( $client, sub {
 		my ($result) = @_;
 
-		my $isWeb = $args->{isControl} && !$client->controlledBy;
+		my $isWeb = $args->{isControl} && !($client && $client->controlledBy);
 
 		$result->{items} = [ 
 			map { 

Slim/Plugin/WiMP/ProtocolHandler.pm

@@ -38,7 +38,7 @@ sub bufferThreshold {
 	$url = $client->playingSong()->track()->url() unless $url =~ /\.(?:fla?c|mp3)$/;
 
 	my ($trackId, $format) = _getStreamParams( $url );
-	return ($format eq 'flac' ? 96 : 32) * ($prefs->get('bufferSecs') || 3); 
+	return ($format eq 'flac' ? 80 : 32) * ($prefs->get('bufferSecs') || 3); 
 }
 
 sub canSeek { 1 }

Slim/Utils/ArtworkCache.pm

@@ -68,6 +68,10 @@ sub set {
 
 	my $ref = $data->{data_ref};
 
+	$data->{content_type} ||= '';
+	$data->{mtime} ||= 0;
+	$data->{original_path} ||= '';
+
 	my $packed = pack( 'A3LS', $data->{content_type}, $data->{mtime}, length( $data->{original_path} ) )
 	 	. $data->{original_path};
 

Slim/Web/Cometd.pm

@@ -410,22 +410,22 @@ sub handler {
 
 				if ( $result->{error} ) {
 
-					my %error = {
+					my $error = {
 						channel => '/slim/subscribe', 
 						error   => $result->{error},
 						id      => $id,
 					};
 
-					push @errors, \%error;
+					push @errors, $error;
 
 					if ($result->{'errorNeedClient'}) {
 						$log->error('errorNeedsClient: ', join(', ', $request->[0], @{$request->[1]}));
 						# Force reconnect because client not connected.
-						# We should not need to force a new handshake, just a reconect.
+						# We should not need to force a new handshake, just a reconnect.
 						# Any successful subscribes will have the acknowledgements in the $events queue
 						# and others will be retried by the client unpon reconnect.
 						# Let the client pick the interval to give SlimProto a chance to reconnect.
-						$error{'advice'} = {
+						$error->{'advice'} = {
 							reconnect => 'retry',
 						};
 

Slim/Web/Pages/Home.pm

@@ -172,22 +172,22 @@ sub home {
 		if (!main::NOBROWSECACHE && $template eq 'home.html') {
 			$checksum = md5_hex(Slim::Utils::Unicode::utf8off(join(':', 
 				($client ? $client->id : ''),
-				$params->{newVersion},
-				$params->{newPlugins},
-				$params->{hasLibrary},
-				$prefs->get('langauge'),
-				$params->{library_id},
-				complex_to_query($params->{additionalLinks}),
-				complex_to_query($params->{additionalLinkOrder}),
+				$params->{newVersion} || '',
+				$params->{newPlugins} || '',
+				$params->{hasLibrary} || '',
+				$prefs->get('language'),
+				$params->{library_id} || '',
+				complex_to_query($params->{additionalLinks} || {}),
+				complex_to_query($params->{additionalLinkOrder} || {}),
 				complex_to_query($params->{cookies} || {}),
 				complex_to_query($params->{favorites} || {}),
-				$params->{'skinOverride'} || $prefs->get('skin'),
-				$template,
-				$params->{song_count},
-				$params->{album_count},
-				$params->{artist_count},
+				$params->{'skinOverride'} || $prefs->get('skin') || '',
+				$template || '',
+				$params->{song_count} || 0,
+				$params->{album_count} || 0,
+				$params->{artist_count} || 0,
 			)));
-		
+
 			if (my $cached = $cache->get($checksum)) {
 				return $cached;
 			}

Slim/Web/Pages/Playlist.pm

@@ -78,7 +78,7 @@ sub playlist {
 		$cacheKey = join(':', 
 			$client->id,
 			$client->currentPlaylistChangeTime(),
-			$prefs->get('langauge'),
+			$prefs->get('language'),
 			$currentSkin,
 			$params->{'start'},
 			$songcount,

Slim/Web/Settings/Server/FileTypes.pm

@@ -45,6 +45,7 @@ sub handler {
 
 			# If the conversion pref is enabled confirm that 
 			# it's allowed to be checked.
+			$paramRef->{$profile} ||= '';
 			if ($paramRef->{$profile} ne 'DISABLED' && $disabledformats{$profile}) {
 
 				if (!Slim::Player::TranscodingHelper::checkBin($profile,'IgnorePrefs')) {
@@ -96,10 +97,11 @@ sub handler {
 						$binstring = undef;
 					}
 				}
+
+				$binstring ||= '';
 			}iegsx;
 
-		if (defined $binstring && $binstring ne '-') {
-
+		if ($binstring && $binstring ne '-') {
 			push @binaries, $binstring;
 
 		} elsif ($cmdline eq '-' || $binstring eq '-') {

Slim/Web/XMLBrowser.pm

@@ -321,6 +321,7 @@ sub handleFeed {
 			if ( 
 				   $subFeed->{'play'} 
 				&& $depth == $levels
+				&& $stash->{'action'}
 				&& $stash->{'action'} =~ /^(?:play|add|insert)$/
 			) {
 				$subFeed->{'type'} = 'audio';
@@ -331,6 +332,7 @@ sub handleFeed {
 			if ( 
 			       $subFeed->{'playlist'}
 				&& $depth == $levels
+				&& $stash->{'action'}
 				&& $stash->{'action'} =~ /^(?:playall|addall|insert|remove)$/
 			) {
 				$subFeed->{'type'} = 'playlist';
@@ -501,7 +503,7 @@ sub handleFeed {
 
 					if ($depth == $levels) {
 						$args{'index'} = $index;
-						$args{'quantity'} = $stash->{'itemsPerPage'} || ($stash->{action} =~ /^(?:play|add)all$/i && $prefs->get('maxPlaylistLength')) || $prefs->get('itemsPerPage');
+						$args{'quantity'} = $stash->{'itemsPerPage'} || ($stash->{action} && $stash->{action} =~ /^(?:play|add)all$/i && $prefs->get('maxPlaylistLength')) || $prefs->get('itemsPerPage');
 					} elsif ($depth < $levels) {
 						$args{'index'} = $index[$depth];
 						$args{'quantity'} = 1;
@@ -654,7 +656,7 @@ sub handleFeed {
 		# XXX: Why is $stash->{streaminfo}->{item} added on here, it seems to be undef?
 		for my $item ( @{ $stash->{'items'} }, $streamItem ) {
 			my $url;
-			if ( $item->{'type'} eq 'audio' && $item->{'url'} ) {
+			if ( $item->{'type'} && $item->{'type'} eq 'audio' && $item->{'url'} ) {
 				$url = $item->{'url'};
 			}
 			elsif ( $item->{'enclosure'} && $item->{'enclosure'}->{'url'} ) {
@@ -760,8 +762,8 @@ sub handleFeed {
 
 		my $itemCount = $feed->{'total'} || scalar @{ $stash->{'items'} };
 
-		my $clientId = ( $client ) ? $client->id : undef;
-		my $otherParams = '&index=' . $crumb[-1]->{index} . '&player=' . $clientId;
+		my $clientId = ( $client ) ? $client->id : '';
+		my $otherParams = '&index=' . ($crumb[-1]->{index} || '') . '&player=' . $clientId;
 		if ( $stash->{'query'} ) {
 			$otherParams = '&query=' . $stash->{'query'} . $otherParams;
 		}
@@ -801,7 +803,7 @@ sub handleFeed {
 		}
 
 		my $item_index = $start;
-		my $format = $stash->{ajaxSearch} || $stash->{type} eq 'search'
+		my $format = $stash->{ajaxSearch} || ($stash->{type} || '') eq 'search'
 			? 'TRACKNUM. TITLE - ALBUM - ARTIST'
 			: $prefs->get('titleFormat')->[ $prefs->get('titleFormatWeb') ];
 
@@ -822,8 +824,8 @@ sub handleFeed {
 			}
 
 			# keep track of station icons
-			if ( 
-				( $_->{play} || $_->{playlist} || ($_->{type} && ($_->{type} eq 'audio' || $_->{type} eq 'playlist')) )
+			if ( $_->{url} && !ref $_->{url}
+				&& ( $_->{play} || $_->{playlist} || ($_->{type} && ($_->{type} eq 'audio' || $_->{type} eq 'playlist')) )
 				&& $_->{url} =~ /^http/ 
 				&& $_->{url} !~ m|\.com/api/\w+/v1/opml| 
 				&& ( my $cover = $_->{image} || $_->{cover} )
@@ -937,7 +939,7 @@ sub handleFeed {
 
 			if ($details->{'unfold'}) {
 				# unfold nested groups of additional items
-				my $new_index;
+				my $new_index = 0;
 				foreach my $group (@{ $details->{'unfold'} }) {
 
 					splice @{ $stash->{'items'} }, ($group->{'start'} + $new_index), 1, @{ $group->{'items'} };
@@ -948,7 +950,7 @@ sub handleFeed {
 
 			$feed->{'favorites_url'} ||= $stash->{'playUrl'};
 
-			if ($feed->{'hasMetadata'} eq 'album' && $feed->{'albumInfo'}) {
+			if ($feed->{'hasMetadata'} && $feed->{'hasMetadata'} eq 'album' && $feed->{'albumInfo'}) {
 
 				my $morelink = _makeWebLink({ actions => $feed->{'albumInfo'} }, $feed, 'info', 
 											sprintf('%s (%s)', string('INFORMATION'), ($feed->{'album'} || '')));
@@ -1076,7 +1078,8 @@ sub handleError {
 
 	my $template = 'xmlbrowser.html';
 
-	my $title = ( uc($params->{title}) eq $params->{title} ) ? Slim::Utils::Strings::getString($params->{title}) : $params->{title};
+	$params->{title} ||= '';
+	my $title = ( $params->{title} && uc($params->{title}) eq $params->{title} ) ? Slim::Utils::Strings::getString($params->{title}) : $params->{title};
 
 	$stash->{'pagetitle'} = $title;
 	$stash->{'pageicon'}  = $params->{pageicon};
@@ -1245,7 +1248,7 @@ sub webLink {
 	push @verbs, 'orderBy:' . $args->{'orderBy'} if $args->{'orderBy'};
 
 	my $renderCacheKey;
-	if ( !main::NOBROWSECACHE && $cacheables{ $args->{path} } && $args->{url_query} !~ /\baction=/ && $args->{url_query} !~ /\bindex=\d+\.\d+\.\d+/ && !Slim::Music::Import->stillScanning() ) {
+	if ( !main::NOBROWSECACHE && $cacheables{ $args->{path} } && !($args->{url_query} && $args->{url_query} =~ /\baction=/) && !($args->{url_query} && $args->{url_query} =~ /\bindex=\d+\.\d+\.\d+/) && !Slim::Music::Import->stillScanning() ) {
 
 		# let cache expire between server restarts
 		$cacheTimestamp ||= time();