Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin file permissions #528

Closed
mavit opened this issue Feb 4, 2021 · 2 comments · Fixed by #533
Closed

Plugin file permissions #528

mavit opened this issue Feb 4, 2021 · 2 comments · Fixed by #533

Comments

@mavit
Copy link
Contributor

mavit commented Feb 4, 2021

For my LMS plugin, I'm using GitLab to automatically pack the latest Git commit into a downloadable zip. It turns out that the default GitLab umask was 0000, and this was carrying over to the permissions of files inside my zip. When LMS downloads and installs the plugin, it respects these permissions, with the outcome that the files for my plugin were all a=rw.

This doesn't seem like something that anyone would ever want. Would it be a sensible precaution to reset the permissions to, say, u=rw,go=r when unpacking?
@michaelherger
Copy link
Member

I'm always a bit hesitant to "fix" issues which haven't been seen in a decade... in particular when they scream "platform support!", too 😀. Would you have a one line fix for this ready to be tested?

mavit added a commit to mavit/slimserver that referenced this issue Feb 7, 2021
@mavit
Strip world-writable file permissions during plugin installation
e36c865 
On Unix-like platforms, ensure that plugins are installed in such a way that none of their files are writable by users other than the user running LMS, even if theyʼre stored that way in the plugin ZIP file.

Fixes LMS-Community#528.
@mavit
Copy link
Contributor Author

mavit commented Feb 7, 2021 •
edited

I'm afraid it stretches to five lines, including a comment. See e36c865.

@mavit mavit mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip world-writable file permissions during plugin installation mavit/slimserver
2 participants
@mavit @michaelherger