Fix album_contributor updates in new & changed scan #962
Conversation
This seems to work, but I wonder if we should put some more thought into how we handle multiple Artist tags - at the moment, tracks.primary_artist is arbitrarily set to the first element in the Artists array. Maybe if there is an ARTIST that is also an ALBUMARTIST (in the music file tags) it should take precedence? (Would also need to bear in mind that there could be multiple ALBUMARTIST tags as well).
Slim/Schema/Contributor.pm
Outdated
| @@ -255,8 +255,9 @@ sub rescan { | |||
| SELECT COUNT(*) FROM contributor_track WHERE contributor = ? | |||
| } ); | |||
|
|
|||
| # There may have be more than one Artist tag in the music file, so track.primary_artist does not tell the whole story. So also check for ARTIST/ALBUMARTIST in contributor_track. | |||
Slim/Schema/Contributor.pm
Outdated
| my $albumSth = $dbh->prepare_cached( qq{ | ||
| SELECT COUNT(1) FROM tracks WHERE album = ? AND primary_artist = ? | ||
| SELECT COUNT(1) FROM tracks JOIN contributor_track ON tracks.id=contributor_track.track WHERE album=? AND ( tracks.primary_artist=? OR contributor_track.contributor=? AND contributor_track.role IN (1,5) ) |
There was a problem hiding this comment.
Could you please format the query to make it more readable?
|
I believe the |
|
I agree. What do you think about changing its population so at least there's a chance of it matching albums.contributor? Or are there people out their with multiple Artist tags who are taking advantage of the fact that for LMS the first one in their music file is "special"? |
|
You can expect people out there to do anything you wouldn't 😂. I think I've seen any assumption we/I did at some point proved wrong at some later point. Remove "the" from the search index? Shouldn't be a problem. Except for "The The". Any album title would have a letter or number? Along came Ed Sheeran with stuff like "÷"... So... I'd like to keep 8.4 relatively stable, not introduce too risky changes in the next few weeks, so I could cut a 8.4 release early next year. Maybe a complete overhaul of |
|
Thanks a lot! Let's give this particular fix a try for now. That way you'll have to deal with one branch less 😉. |
This seems to work, but I wonder if we should put some more thought into how we handle multiple Artist tags - at the moment, tracks.primary_artist is arbitrarily set to the first element in the Artists array.
Maybe if there is an ARTIST that is also an ALBUMARTIST (in the music file tags) it should take precedence? (Would also need to bear in mind that there could be multiple ALBUMARTIST tags as well).