Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix album_contributor updates in new & changed scan #962

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix album_contributor updates in new & changed scan #962

merged 2 commits into from
Dec 20, 2023

Commits on Dec 19, 2023

  1. Fix album_contributor updates in new & changed scan 

    This seems to work, but I wonder if we should put some more thought into how we handle multiple Artist tags - at the moment, tracks.primary_artist is arbitrarily set to the first element in the Artists array.

Maybe if there is an ARTIST that is also an ALBUMARTIST (in the music file tags) it should take precedence? (Would also need to bear in mind that there could be multiple ALBUMARTIST tags as well).
    @darrell-k
    darrell-k committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1602675 View commit details
    Browse the repository at this point in the history

  2. Tidy up 

    Also made it a LEFT JOIN to cater for the unlikely situation where there are no contributor_track matches.
    @darrell-k
    darrell-k committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    4edd0fb View commit details
    Browse the repository at this point in the history