Correction to Album listing (Default Skin) Track favourites link #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://forums.slimdevices.com/forum/user-forums/logitech-media-server/1681581-track-favourites-in-default-skin The problem is that $songinfo (in Slim/Web/XMLBrowser.pm) always contains the album header info in the album view, so it should not be used to create a track favourite. I'm looking at $item instead, if it's a track (type==audio). I've tried to be as light-touch as possible in this change, but: 1. Has it really been wrong effectively for ever? 2. Is this the best way of addressing the problem?
Slim/Menu/BrowseLibrary.pm
Outdated
| @@ -1795,6 +1795,8 @@ sub _tracks { | |||
| delete $_->{'artwork_track_id'}; | |||
| $_->{'playall'} = 1; | |||
| } | |||
|
|
|||
| $_->{'favorites_url'} = $_->{'url'}; | |||
There was a problem hiding this comment.
Why not just use the item.url in the template? Would save one more line change.
There was a problem hiding this comment.
You're right. I added that before full investigation, just in case its existence solved the problem. I'll remove it.
|
Thanks! |
This was referenced Mar 19, 2024
darrell-k
pushed a commit
to darrell-k/slimserver
that referenced
this pull request
Mar 19, 2024
michaelherger
pushed a commit
that referenced
this pull request
Mar 20, 2024
…er to get the valid icon from the URL we (unfortunately) require a client object at this point. But in most cases we do have that, we only need to pass it around from within `Slim::Web::XMLBrowser`. Don't use the `favorite_url` on songinfo in the web UI, as that would refer to the album rather than the track. This is a slightly different approach at fixing #1007.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forums.slimdevices.com/forum/user-forums/logitech-media-server/1681581-track-favourites-in-default-skin
The problem is that $songinfo (in Slim/Web/XMLBrowser.pm) always contains the album header info in the album view, so it should not be used to create a track favourite. I'm looking at $item instead, if it's a track (type==audio).
I've tried to be as light-touch as possible in this change, but: