Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for composers, conductors and works #1048

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

terual
Copy link
Member

@terual terual commented Apr 10, 2024

As requested in #1046 (and added icon for conductors and composers for good measure)

@michaelherger
Copy link
Member

Oh wow!... you just qualified as the icon artist! Would you have a template how to create that depth effect? I tried to do this using gimp, but failed...

May I ask you to tweak the "works.png", to give it a bigger margin top/bottom?

@terual
Copy link
Member Author

terual commented Apr 11, 2024

You mean to reduce the size of the treble clef?

@terual
Copy link
Member Author

terual commented Apr 11, 2024

I have changed the size of the clef, is it better like this?

BTW, this is all made in Inkscape, so I can share the template svg I made. Do we want to store the template inside of the source tree?

@michaelherger
Copy link
Member

Excellent! Yes, please, if you could share the template. Probably on lyrion.org rather than the source repository?

@michaelherger michaelherger merged commit 4230142 into LMS-Community:public/9.0 Apr 11, 2024
@terual terual deleted the icons branch April 11, 2024 08:18
@michaelherger
Copy link
Member

BTW: I'd usually send images through ImageOptim (https://imageoptim.com/mac - Mac only), which in turn seems to be using TinyPNG (https://tinypng.com), which easily squeezes out 50% of the image size:

Screenshot 2024-04-11 at 10 24 14

@terual
Copy link
Member Author

terual commented Apr 11, 2024

...I ran optipng -o7 works.png before commiting. Weird that further optimization is still possible then.

@terual terual mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants