Hide library folders from scanning with a sentinel file. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelherger
requested changes
Sep 30, 2020
michaelherger
requested changes
Oct 1, 2020
HTML/EN/settings/server/basic.html
Outdated
| @@ -89,6 +89,12 @@ | |||
| [% END %] | |||
| [% END %] | |||
|
|
|||
| [% WRAPPER settingSection %] | |||
There was a problem hiding this comment.
Please move this out of basic settings to My Music instead.
There was a problem hiding this comment.
Moved $skipsentinel into folderFilter() sub.
I'm not sure if My Music is the right place for the skipsentinel setting. My Music deals with music (meta)data content. Skipsentinel operates on the scanning level, not the content level.
There was a problem hiding this comment.
It's a better place than Basic Settings, as it's an advanced setting. Please :-).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a vast collection of music, mostly ripped CDs, but not all of them are eligible to be included in the LMS library. So many years ago (2007 to be precise) I added a small tweak to function
folderFilter(moduleSlim::Utils::Misc) to stop scanning a folder when a sentinel file.slimskipis present.Since this may be interesting for other users as well (and because I always forget to re-apply this tweak after an upgrade) I hereby present it as a formal pull request.