Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to combine channels #537

Merged
merged 2 commits into from Feb 21, 2021

Conversation

philippe44
Copy link
Contributor

@philippe44 philippe44 commented Feb 21, 2021

Allow channels to be combined for mono playback, even when player is not synchronized. See ralph-irving/squeezelite#131.

I've verified with a Boom and a Radio that it did not create issues and I've also updated squeezelite-esp32.

I'm not sure this is a very important modification as nobody has been crying for it so far :-)

Copy link
Contributor

@mherger mherger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the wording, would you mind adding a line to the changelog? Thanks!

strings.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@mherger mherger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@mherger mherger merged commit 84427f9 into LMS-Community:public/8.2 Feb 21, 2021
@CornelisJ
Copy link

I can confirm that mono output channel mode is now working for my SqueezeAMP with squeezelite-esp32 v571.
One observation is that when selecting mono output channel mode for SqueezePlay for Windows, only the left channel audio is outputted on both speaker outputs. See https://forums.slimdevices.com/showthread.php?112697-ANNOUNCE-Squeezelite-ESP32-(dedicated-thread)&p=1011043&viewfull=1#post1011043

@ralph-irving
Copy link

I plan to add support for this mode to squeezeplay and the community firmware.

@CornelisJ
Copy link

I can confirm that the Mono output channel mode is now also working OK with:

  • Squeezelite v1.9.9-1356-pCP
  • Squeezeplay for Windows 8.0.1-r1360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants