mp4 parser for trailing header must keep original request fields #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keep them coming! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another one that I discover with mixcloud. Some mp4 files have their headers at the end of the file, after the audio. The parser handles that and jumps there, except that it is creating a new HTTP::Request and if the original one has some custom headers (like user-agent in the case of mixcloud), then they are not preserved and the parsing might fail.
I missed that in my tests because I was using an LMS version with a default user-agent of "Mozilla/5.0"... of course. This PR re-uses the original HTTP::Request but just add the Range field. I recommend applying that against 8.1 otherwise mixcloud will not work