Update Commands.pm to randomize certain ["playlist", "loadtracks"] actions #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed simple change shuffles the @tracks array produced by calls to ["playlist", "loadtracks"] when any of track.titlesearch, contributor.namesearch, or genre.id are used as search criteria.
When these criteria are used, there is by definition no inherent expectation of preservation of order (as there would be for e.g. an album). However, LMS currently always returns exactly the same @tracks array when ["playlist", "loadtracks"] is used. This is indeed shuffled if the player in question has shuffle enabled, but if the player has it disabled (e.g. because the user never shuffles albums) then the result is always the same which, as mentioned in the forum, is boring.
List::Util qw(shuffle) is a core module so should not cause any dependency issues.