Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Song/track/handler for url refactoring attempt #612

Merged
merged 12 commits into from
Jun 14, 2021
Merged

Song/track/handler for url refactoring attempt #612

merged 12 commits into from
Jun 14, 2021

Commits on Jun 9, 2021

  1. attempt to refactor handlerForUrl & song vs track naming

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    7b30413 View commit details
    Browse the repository at this point in the history

  2. fix open items

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b0b071a View commit details
    Browse the repository at this point in the history

  3. move back to songHandler & urlHandler 

    They are both needed (surprise...) when PH's don't descend from HTTP. Now, the requestString needed to be updated
    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    828675e View commit details
    Browse the repository at this point in the history

  4. use $song in getMetadataFor only for current song

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1f58ad6 View commit details
    Browse the repository at this point in the history

  5. undo cosmetic changes

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    749dfca View commit details
    Browse the repository at this point in the history

  6. use songhandler core, not track

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    cb1cc4e View commit details
    Browse the repository at this point in the history

  7. fixes

    @philippe44
    philippe44 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    68b9cd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. use currentTrack when possible

    @philippe44
    philippe44 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    b647d71 View commit details
    Browse the repository at this point in the history

  2. oversight: streamUrl must be used in canDirectStreamSong

    @philippe44
    philippe44 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    016847d View commit details
    Browse the repository at this point in the history

  3. a few more

    @philippe44
    philippe44 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8f2184f View commit details
    Browse the repository at this point in the history

  4. remove canDirectStreamSong in PH 

    This is un-necesseary  as the objective was to call SUPER::canDirectStream. Now that we have a S::P::P::HTTP(S)::canDirectStreamSong, it will take care of that
    @philippe44
    philippe44 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    d6267c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. adding some random comments

    @philippe44
    philippe44 committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    853c4cb View commit details
    Browse the repository at this point in the history