adding a search function to podcast #621
Conversation
There was a problem hiding this comment.
Only a quick review so far - haven't had time to actually play with it.
Overall I like the idea and the approach to support multiple sources in a generic way. But I'm not sure we can use Apple. Maybe we should implement gpodder by default, but provide a hook for 3rd parties to register additional sources like Apple or podcastindex.org (requires an API key, I believe). Then I would whip up a small plugin to add those other sources.
Slim/Plugin/Podcast/Search.pm
Outdated
| title => 'collectionName', | ||
| image => ['artworkUrl600', 'artworkUrl100'], | ||
| setup => sub { | ||
| my $url = 'https://itunes.apple.com/search?media=podcast&term=' . shift; |
There was a problem hiding this comment.
Do you know whether this endpoint is open to the public?
Slim/Plugin/Podcast/Search.pm
Outdated
| my $log = logger('plugin.podcast'); | ||
| my $prefs = preferences('plugin.podcast'); | ||
|
|
||
| my @providers = ( { |
|
I pushed a few changes I suggested above to a new branch. But I believe I can't submit a pull request because it's based on a pull request of yours... You'll find my commit in fbed42c |
|
If we can find a way to add a feed to the list, I think that would be enough TLC for this plugin. Anything more would mean searching and browsing episodes themselves which I think is way beyond the scope of this plugin - IMHO. |
|
Re latest commit, I thought that you might prefer to have the extra menu (trending) out of the core LMS as it is not super UI-clean. The small extension mechanism will allow that to be added as a tiny plugin |
|
I've created a basic podcast-extension here https://github.com/philippe44/LMS-PodcastExt |
…yles. Still haven't figured out how to add the menu to the subscribed shows.
|
I've made a fair bit of refactoring b/c I realized I was reinventing the OO wheel too much. So I moved providers to a proper class solution. @mherger, I've included all your modficiations |
This adds the possibility to search feeds with a choice of providers. It's basic, including the possibility to switch provider (inspired by material). One thing I'm missing is the possibility to subscribe directly by adding an icon on the feed list, but I don't know if this is possible to have a custom handler there