Allow mysb based playlists from Deezer to be played #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a ready for use PR, but just a status of where I am wrt playlists as favorites for protocol handler like Deezer.
First, I'm not sure this is not a complex solution for a simple problem => when I add the result of a Deezer menu item (say a search for album) as a favorite, the favorites.opml registers the http:// link with the search keys/values with a type "playlist". As far as I can see, it is all fine then, I can later browse that favorite and play it. When playing it, the player's tracklist is loaded with all the tracks. There is no need of "exploding" anything as LMS use getFeedAsync to obtain the sub-items of that favorite, because it's a feed type "playlist" and then LMS populates the tracklist with individual items.
Now, if the favorite is a type "audio" and not "playlist", it's a different story as here what LMS handles it not an opml feed, but a "source" playlist like in m3u (not sure I got my terminology right). That mean that it is not a browsable item and when played, a single item will be added to the tracklist. When going through tracks of that playlist, visually we'll stay on the single playlist entry, but we go through real tracks one by one. That's where LMS uses the difference between _track and _currentTrack (see my long comment in DEVELOPERS.txt) where _track is the playlist's entry that never changes and _currentTrack is the individual "real" track that is currently playing.
So that PR deals with that type of playlist when they are Deezer entries. Is this really needed? I don't know as, per above, so far when I add a Deezer menu item a favorite, it comes with a "playlist" type, so it works as a browsable opml feed.