Podcasts: Pre-caching image data - do not continually try again when there is no image to be had #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not mandatory that a podcast feed provide an image, and it is not helpful to attempt a refresh every day just because one is absent. This is not an error condition. So treat the default image just as if it were a 'real' image, caching for around 90 days. The image data will be updated when the user browses into the feed, so any future change will be picked up within a reasonable time period.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is a follow up to #668.
Some podcasts do not provide image data in their feeds. This is quite acceptable.
In this case we provide a default image, but only for 24 hours. Thereafter we just fetch the feed again, and re-try. That is unnecessary. If there's no image, well, there's just no image. There is no point in continually trying again.
This proposed change has us adopt the same circa 90 day policy to the default image that is applied to "real" images.