Fix player sync #777
Merged
Fix player sync #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! Can you give me an example request which would show the wrong behaviour? |
|
00:04:20:1e:e4:a0 sync 00:04:20:06:fd:5e The first player is the one I use as "master". And if the second player is turned off (disconnected), a random of my other players would be added to the sync group (based on the order of the players in the clients array). It can also be reproduced by using a random MAC as the second player. |
Slim/Control/Commands.pm
Outdated
Comment on lines
3079
to
3082
| if (!defined $buddy) { | ||
| my @clients = Slim::Player::Client::clients(); | ||
| if (defined $clients[$newbuddy]) { | ||
| if (looks_like_number($newbuddy) && defined $clients[$newbuddy]) { | ||
| $buddy = $clients[$newbuddy]; |
There was a problem hiding this comment.
Please move the new check to the outer condition. There's no need to read the @clients list if the $newbuddy isn't a number.
And feel free to update Changelog8.html too.
There was a problem hiding this comment.
I have updated the PR
Updated changelog
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the sync command through the CLI with an unknown playerid, the first player in the clients array would be added (instead of ignoring the unknown playerid).
This PR should fix that.