Fix installation of plugin updates - honour user's choice #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects the behaviour of the Plugin management settings page.
At present, an available plugin update will be installed whenever settings are
saved, without regard to the user's choice in the matter.
The settings page provides the user with a checkbox option that should
determine whether or not the update is installed. But the state of this option
is not being properly determined.
The problem lies with the use of the condition 'exists $params->{"install:$plugin"}'.
This condition will be set true when a plugin has been selected for first time
installation. But it is also set true while the plugin remains installed.
The condition 'exists $params->{"update:$plugin"}' indicates that the user has
chosen to install an update.
The current logic assumes that only one of the conditions
'exists $params->{"install:$plugin"}' and 'exists $params->{"update:$plugin"}'
will ever be true at the same time. Were that the case, the code would cater
for both first time installation and update installation correctly. But the
assumption is incorrect. 'exists $params->{"install:$plugin"}' is also true
whenever a plugin update is available.
The consequence is that plugin updates are installed without regard to the
user's choice.
This change deals with the issue by distinguishing a first time installation
from the installation of a subsequent update, and using the correct logic for
each case.
|
Looking good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change corrects the behaviour of the Plugin management settings page.
When a plugin update is available, the settings page provides the user with a checkbox option that should determine whether or not the update is to be installed. But, at present, the update will always be performed regardless of the user's choice.
The issue was raised in this forum post: Plugins update when not selected.
The proposed change corrects this behaviour. Plugins will now only be updated if the user has explicitly made the choice, or if plugins are updated automatically (setting: 'Update plugins automatically'). It has been tested both in LMS' default skin, and in the Material skin.