Fix no-transcoding playback #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you want to back port this to 8.3 at some point? Or could it go into 8.3 right away? |
|
It can go right away |
|
Ouch... tried to rebase against 8.3, but that didn't go well... I'll cherry pick on my end. Thanks! |
|
Applied in commit 395cb30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://forums.slimdevices.com/showthread.php?117085-LMS-8-1-1-(and-above)-break-radio-streaming-on-SB-Radio when user sets "--notranscoding", the byte format for mp4/aac was left to mp4 because the actual desired format is now a song's attribute that was not net.