Bugfix: HTTPSocks.pm - Binary OR used by mistake - Logical OR needed #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPSocks.pm The binary OR operator (single pipe character) has been inadvertently used in place of the intended logical OR operator (double pipe char). This was typo in change LMS-Community#562 - flac & socks fixes. Refer: LMS-Community@907a6a Async/HTTP.pm Remove redundant comment. The code to which this referred was refactored away some years ago.
|
Good catch! Should have been mine 😀. |
|
Indeed (not that it should have been yours @mherger, but it's a good catch that did not bite because it was a numeric field with 0 as a default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fell across these two items by chance recently, so offer them up while fresh in my mind.
The binary OR operator
|has been inadvertently used in place of the intended logical OR operator||.This was typo in PR #562 - flac & socks fixes. Refer commit: 907a6a
The error/typo is quite obvious when you examine the commit, but @philippe44 (author) might like to confirm.
It could result in some 'hard to fathom out' socks connection failures if left as is.
Remove redundant comment. The code to which this referred was refactored away some years ago.