make lyrics on Default skin songinfo page collapsible #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! Thanks a lot. Would you mind moving the style changes to Oh, and please feel free to add a line to the Changelog. |
|
Ok, so I hope it's all ok and I didn't break anything ;-) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lyrics on the LMS Default skin's song info page would be displayed as collapsed by default. Items below lyrics wouldn't be pushed so far out of sight - and lyrics are just one click away.
To keep it simple it uses html details/summary which has excellent browser support (exception: deprecated IE and Opera mini).