add OggFlac support #987
Merged
add OggFlac support #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherger
reviewed
Jan 31, 2024
Slim/Formats/FLAC.pm
Outdated
| @@ -265,7 +265,7 @@ sub _addInfoTags { | |||
| $tags->{SIZE} = $info->{file_size}; | |||
| $tags->{SECS} = $info->{song_length_ms} / 1000; | |||
| $tags->{OFFSET} = 0; # the header is an important part of the file. don't skip it | |||
| $tags->{BITRATE} = sprintf "%d", $info->{bitrate}; | |||
| $tags->{BITRATE} = sprintf "%d", ($info->{bitrate} || $info->{bitrage_ogg}); | |||
There was a problem hiding this comment.
Is there a bit of a rage in Ogg? 😁
Don't know whether this typo is needed for compatibility with Audio::Scan?
|
Would merging this before updating Audio::Scan break anything which previously worked? |
|
I will let the rage cool down a bit 😄 and I'll run some test with 1.09. If needed, I'll change OggFlac.pm to deal with the error cases that might happen then. |
|
ok - rage is gone and I've tried with current Audio::Scan and it behaves as expected: the ogf files are scanned but no relevant data is returned so they can be played but not seek through. I don't think it will create a problem, the only difference with today is that ogf are now part of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes OggFlac file support, including seeking. It needs LMS-Community/Audio-Scan#5. Now, I think that by just not changing types.conf, all these changes are disabled and won't matter.