fix(channels): neutrino clients manual channels flagged private

.flowconfig

@@ -9,6 +9,7 @@
 <PROJECT_ROOT>/dll/.*
 <PROJECT_ROOT>/release/.*
 <PROJECT_ROOT>/git/.*
+<PROJECT_ROOT>/.git/.*
 
 [include]
 

app/lib/lnd/methods/channelController.js

@@ -19,13 +19,14 @@ function ensurePeerConnected(lnd, pubkey, host) {
  * @return {[type]}         [description]
  */
 export function connectAndOpen(lnd, event, payload) {
-  const { pubkey, host, localamt } = payload
+  const { pubkey, host, localamt, private: privateChannel } = payload
 
   return ensurePeerConnected(lnd, pubkey, host)
     .then(() => {
       const call = lnd.openChannel({
         node_pubkey: Buffer.from(pubkey, 'hex'),
-        local_funding_amount: Number(localamt)
+        local_funding_amount: Number(localamt),
+        private: privateChannel
       })
 
       call.on('data', data => event.sender.send('pushchannelupdated', { pubkey, data }))

app/reducers/channels.js

@@ -1,5 +1,6 @@
 import { createSelector } from 'reselect'
 import { ipcRenderer } from 'electron'
+import Store from 'electron-store'
 import { btc } from 'lib/utils'
 import { showNotification } from 'lib/utils/notifications'
 import { requestSuggestedNodes } from 'lib/utils/api'
@@ -191,7 +192,18 @@ export const openChannel = ({ pubkey, host, local_amt }) => (dispatch, getState)
   dispatch(openingChannel())
   dispatch(addLoadingPubkey(pubkey))
 
-  ipcRenderer.send('lnd', { msg: 'connectAndOpen', data: { pubkey, host, localamt } })
+  // Grab the activeConnection type from our local store.
+  // If the active connection type is local (light clients using neutrino)
+  // we will flag manually created channels as private. Other connections
+  // like remote node and BTCPay Server we will announce to the network as
+  // these users are using Zap to drive nodes that are online 24/7
+  const store = new Store({ name: 'settings' })
+  const { type } = store.get('activeConnection', null)
+
+  ipcRenderer.send('lnd', {
+    msg: 'connectAndOpen',
+    data: { pubkey, host, localamt, private: type === 'local' }
+  })
 }
 
 // TODO: Decide how to handle streamed updates for channels

flow-typed/module_vx.x.x.js

@@ -1,3 +1,3 @@
-declare module 'module' {
+declare module 'grpc' {
   declare module.exports: any;
 }

test/unit/reducers/channels.spec.js

@@ -1,3 +1,5 @@
+// @flow
+
 import channelsReducer, {
   SET_CHANNEL_FORM,
   SET_CHANNEL,
@@ -8,6 +10,16 @@ import channelsReducer, {
   OPENING_FAILURE
 } from 'reducers/channels'
 
+jest.mock('electron', () => {
+  const { normalize } = require('path')
+  return {
+    app: {
+      getPath: name => normalize(`/tmp/zap-test/${name}`),
+      getAppPath: () => normalize('/tmp/zap-test')
+    }
+  }
+})
+
 describe('reducers', () => {
   describe('channelsReducer', () => {
     it('should handle initial state', () => {