Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Can't send on invoice that has 0 amount #1046

Closed
JimmyMow opened this issue Dec 8, 2018 · 1 comment
Closed

Can't send on invoice that has 0 amount #1046

JimmyMow opened this issue Dec 8, 2018 · 1 comment
Assignees
@mrfelton
Labels
branch: next type: enhancement New feature or request
Milestone
v0.3.0-beta

Comments

@JimmyMow
Copy link
Member

JimmyMow commented Dec 8, 2018 •
edited by mrfelton

Description

When I click on an invoice that has the amount set to 0 Zap doesn't allow me to send. With invoices set to 0 the sender can set what amount they'd like to send over.

Expected Behavior

When I click an invoice that has the amount set to 0 I would like to be able to set the amount and then attempt to send

Actual Behavior

Zap errors out and doesn't let me send:

screen shot 2018-12-07 at 8 49 53 pm

Proposed Solution

If the invoice amount is 0, add an additional step to the payment form to allow the user to enter a custom amount.

image

Steps to Reproduce

You can test 0 amount invoices with https://tippin.me

Your Environment

Zap Desktop Next branch
@mrfelton mrfelton added this to the v0.3.0-beta milestone Dec 8, 2018
@ZapUser77 ZapUser77 mentioned this issue Dec 9, 2018
Closed
@mrfelton mrfelton reopened this Dec 10, 2018
@mrfelton mrfelton self-assigned this Dec 10, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
c760c03 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
687e44a 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
4d3bc90 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
0bf1740 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
40d1878 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
b3a215e 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 11, 2018
@mrfelton
feat(invoice): support zero amount invoices
c5ecfa7 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix LN-Zap#1046
@JimmyMow
Copy link
Member Author

Closing due to #1069 being merged

mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
feat(invoice): support zero amount invoices
65157bd 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix #1046
mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
feat(invoice): support zero amount invoices
e57b812 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix #1046
mrfelton added a commit that referenced this issue Dec 15, 2018
@mrfelton
feat(invoice): support zero amount invoices
f9c272d 
Add support for zero amount invoices by allowing the user to set the
amount to pay manually in the case that the invoice amount is zero.

Fix #1046
@mrfelton mrfelton added type: enhancement New feature or request and removed type: enhancement labels Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
branch: next type: enhancement New feature or request
Projects
None yet
Milestone
v0.3.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @JimmyMow