Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add ability to edit remote connection settings that use lndconnect #1624

Closed
korhaliv opened this issue Feb 22, 2019 · 3 comments
Closed

Add ability to edit remote connection settings that use lndconnect #1624

korhaliv opened this issue Feb 22, 2019 · 3 comments
Assignees
@korhaliv
Labels
scope: onboarding issues relating to the onboarding process scope: ui/ux issues with user interface or user experience in general type: enhancement New feature or request
Milestone
v0.4.0-beta

Comments

@korhaliv
Copy link
Member

korhaliv commented Feb 22, 2019 •
edited by mrfelton

Detailed Description

Currently you are only allowed (#1620) to edit host, cert and macaroon if you've used paths to setup your node as opposed to lndconnect uri

Possible Implementation

Allow to paste/edit the entire lndconnect uri but also introduce some way to make it hidden by default for security reasons.

image
@korhaliv korhaliv added the status: needs design issue needs designs label Feb 22, 2019
@korhaliv korhaliv added this to the v0.4.0-beta milestone Feb 22, 2019
@mrfelton mrfelton added type: enhancement New feature or request scope: ui/ux issues with user interface or user experience in general scope: onboarding issues relating to the onboarding process and removed status: needs design issue needs designs labels Mar 5, 2019
@mrfelton mrfelton changed the title Add ability to add remote connection settings that use lndconnect Add ability to edit remote connection settings that use lndconnect Mar 5, 2019
@korhaliv korhaliv self-assigned this Mar 5, 2019
@korhaliv
Copy link
Member Author

korhaliv commented Mar 5, 2019

@mrfelton I think TextArea should not be editable in hidden mode, otherwise it doesn't really make sense because lndconnectUri will be overridden with some garbage

@mrfelton
Copy link
Member

mrfelton commented Mar 5, 2019

makes sense @korhaliv

korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Mar 6, 2019
@korhaliv
feat(ui): add ability to edit remote connections that use lndconnect
31db762 
fix LN-Zap#1624
korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Mar 6, 2019
@korhaliv
feat(ui): add ability to edit remote connections that use lndconnect
1887912 
fix LN-Zap#1624
@korhaliv korhaliv mentioned this issue Mar 6, 2019
Merged
6 tasks
korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Mar 7, 2019
@korhaliv
feat(ui): add ability to edit remote connections that use lndconnect
dbfd5c8 
fix LN-Zap#1624
korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Mar 7, 2019
@korhaliv
feat(ui): add ability to edit remote connections that use lndconnect
6f9c6a4 
fix LN-Zap#1624
korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Mar 7, 2019
@korhaliv
feat(ui): add ability to edit remote connections that use lndconnect
04175e9 
fix LN-Zap#1624
@mrfelton
Copy link
Member

mrfelton commented Mar 7, 2019

Fixed via #1718

@mrfelton mrfelton closed this as completed Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@korhaliv korhaliv

Labels
scope: onboarding issues relating to the onboarding process scope: ui/ux issues with user interface or user experience in general type: enhancement New feature or request
Projects
None yet
Milestone
v0.4.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @korhaliv