Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(wallet): support uppercase payment requests #1275

Merged
merged 3 commits into from Jan 7, 2019

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Jan 7, 2019

Description:

Add support for uppercase payment requests.

I've patched bolt11 to support this. See bitcoinjs/bolt11#12

Motivation and Context:

Fix #1266

How Has This Been Tested?

  • Convert a payment request to all uppercase and verify it can be used as expected.
  • Verify normal payment requests continue to function as normal

Types of changes:

Bug fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: bug 🐛 Something isn't working scope: wallet issues with the wallet interface labels Jan 7, 2019
@mrfelton mrfelton added this to the v0.3.3-beta milestone Jan 7, 2019
@mrfelton mrfelton self-assigned this Jan 7, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 18.663% when pulling 49e7b6e on mrfelton:fix/uppercase-bech32 into f33c5fd on LN-Zap:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 18.663% when pulling 49e7b6e on mrfelton:fix/uppercase-bech32 into f33c5fd on LN-Zap:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 18.663% when pulling 49e7b6e on mrfelton:fix/uppercase-bech32 into f33c5fd on LN-Zap:master.

@JimmyMow
Copy link
Member

JimmyMow commented Jan 7, 2019

Tested ACK 49e7b6e

@JimmyMow JimmyMow merged commit 3ed8080 into LN-Zap:master Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upper case bech32 not recognized
3 participants