Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

refactor: extract libs and electron code to project root #1895

Merged
merged 2 commits into from Mar 27, 2019
Merged

refactor: extract libs and electron code to project root #1895

merged 2 commits into from Mar 27, 2019

Conversation

mrfelton
Copy link
Member

Description:

Extract libs and electron code to project root

Motivation and Context:

Make codebase easier to follow and simpler to grok for new users.

How Has This Been Tested?

Manually

  • yarn dev
  • yarn start
  • yarn package

Types of changes:

Refactor

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: refactor Improvement to the codebase label Mar 25, 2019
@mrfelton mrfelton added this to the v0.4.1-beta milestone Mar 25, 2019
@mrfelton mrfelton self-assigned this Mar 25, 2019
@mrfelton mrfelton force-pushed the refactor/reorg branch 2 times, most recently from dd3cc4a to 7e3d30a Compare March 25, 2019 22:20
@mrfelton mrfelton requested a review from korhaliv March 25, 2019 22:28
@mrfelton mrfelton force-pushed the refactor/reorg branch 3 times, most recently from 1a1c1bc to 6ea00ba Compare March 26, 2019 09:26
korhaliv
korhaliv approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 6ea00ba

@coveralls
Copy link

coveralls commented Mar 26, 2019 •
edited

Coverage Status

Coverage decreased (-1.5%) to 19.508% when pulling 2f92308 on mrfelton:refactor/reorg into 027223d on LN-Zap:master.

@mrfelton mrfelton merged commit ad08942 into LN-Zap:master Mar 27, 2019
@mrfelton mrfelton deleted the refactor/reorg branch March 27, 2019 11:11
@mrfelton mrfelton mentioned this pull request Apr 2, 2019
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@korhaliv korhaliv korhaliv approved these changes

Assignees

@mrfelton mrfelton

Labels
type: refactor Improvement to the codebase
Projects
None yet
Milestone
v0.4.1-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrfelton @coveralls @korhaliv