Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(linux): provide desktop app icon #2050

Merged
merged 1 commit into from Apr 18, 2019

Conversation

mrfelton
Copy link
Member

Description:

Provide desktop app icon

Motivation and Context:

fix #2014

How Has This Been Tested?

Manually (build on linux, install, and check icon in dock and launcher)

Screenshots:

image

image

Types of changes:

Bug fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Apr 16, 2019
@mrfelton mrfelton added this to the v0.4.2-beta milestone Apr 16, 2019
@mrfelton mrfelton requested a review from korhaliv April 16, 2019 19:53
@mrfelton mrfelton self-assigned this Apr 16, 2019
@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage remained the same at 19.425% when pulling 2f3d8b4 on mrfelton:fix/linux-app-icon into 020e639 on LN-Zap:master.

Copy link
Member

@JimmyMow JimmyMow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2f3d8b4

@mrfelton mrfelton merged commit 41d18d9 into LN-Zap:master Apr 18, 2019
@mrfelton mrfelton deleted the fix/linux-app-icon branch April 18, 2019 06:18
@mrfelton mrfelton modified the milestones: v0.4.2-beta, v0.5.0-beta Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux AppImage installation lacks icon
3 participants