Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

feat(ui): confirm password on wallet create #3057

Merged
merged 4 commits into from Oct 28, 2019

Conversation

mrfelton
Copy link
Member

Description:

Require the user to conform their new password when creating a new wallet.

Motivation and Context:

If a user makes a type when creating their wallet, they will not be able to log into their wallet ever again.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes:

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: enhancement New feature or request label Oct 26, 2019
@mrfelton mrfelton added this to the v0.6.0-beta milestone Oct 26, 2019
@mrfelton mrfelton self-assigned this Oct 26, 2019
@coveralls
Copy link

coveralls commented Oct 26, 2019

Coverage Status

Coverage decreased (-0.02%) to 22.713% when pulling d405205 on mrfelton:feat/password-confirm into 81f163e on LN-Zap:next.

Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK d405205

@mrfelton mrfelton merged commit c98bc72 into LN-Zap:next Oct 28, 2019
@mrfelton mrfelton deleted the feat/password-confirm branch October 28, 2019 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants