Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update to lnd 0.9 and support keysend #3393

Merged
merged 16 commits into from Mar 24, 2020
Merged

Update to lnd 0.9 and support keysend #3393

merged 16 commits into from Mar 24, 2020

Conversation

mrfelton
Copy link
Member

Description:

Updates to lnd 0.9.1 and adds support for keysend.

Motivation and Context:

Update to latest lnd and support jeysend
Fix #3338
Fix #3333

How Has This Been Tested?

Manually

Types of changes:

Features

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: enhancement New feature or request scope: lnd issues with lnd labels Mar 20, 2020
@mrfelton mrfelton added this to the v0.7.0-beta milestone Mar 20, 2020
@mrfelton mrfelton requested a review from korhaliv March 20, 2020 09:57
@mrfelton mrfelton self-assigned this Mar 20, 2020
@mrfelton mrfelton force-pushed the feat/lnd-0.9 branch 2 times, most recently from 648ae2d to db9d178 Compare March 22, 2020 10:43
@coveralls
Copy link

coveralls commented Mar 22, 2020 •
edited

Coverage Status

Coverage decreased (-0.05%) to 22.542% when pulling 720953f on feat/lnd-0.9 into a6de333 on next.

korhaliv
korhaliv suggested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

renderer/components/Pay/Pay.js Outdated Show resolved Hide resolved
renderer/components/Pay/PayPanelFooter.js Outdated Show resolved Hide resolved
renderer/components/Pay/PayPanelFooter.js Outdated Show resolved Hide resolved
utils/crypto.js Outdated Show resolved Hide resolved
renderer/components/Pay/PaySummaryLightning.js Outdated Show resolved Hide resolved
renderer/components/Pay/PayPanelFooter.js Outdated Show resolved Hide resolved
renderer/components/Pay/PayPanelBody.js
isOnchain: PropTypes.bool,
isPubkey: PropTypes.bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ripe to be replaced with ENUM. but that might be out of scope, so we can create a "refactor" issue for this

renderer/reducers/payment.js Outdated Show resolved Hide resolved
@mrfelton mrfelton mentioned this pull request Mar 24, 2020
Closed
@mrfelton mrfelton requested a review from korhaliv March 24, 2020 11:03
korhaliv
korhaliv approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 120c74b

@mrfelton mrfelton merged commit 0512292 into next Mar 24, 2020
@mrfelton mrfelton deleted the feat/lnd-0.9 branch March 24, 2020 11:47
This was referenced Mar 24, 2020
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@korhaliv korhaliv korhaliv approved these changes

Assignees

@mrfelton mrfelton

Labels
scope: lnd issues with lnd type: enhancement New feature or request
Projects
None yet
Milestone
v0.7.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrfelton @coveralls @korhaliv