This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Support for Hold invoices #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
feat/hold-invoices
branch
from
e4e2cff
to
00b130b
Compare
mrfelton
force-pushed
the
feat/hold-invoices
branch
from
00b130b
to
4044add
Compare
mrfelton
force-pushed
the
feat/hold-invoices
branch
from
4044add
to
f145097
Compare
korhaliv
reviewed
Jul 6, 2020
| const isSettled = invoice.state ? invoice.state === 'SETTLED' : invoice.settled | ||
|
|
||
| const isCancelled = invoice.state === 'CANCELED' |
There was a problem hiding this comment.
Might be a good idea to extract a constant because string is 'CANCE_L_E' (one L) while the var name is cancelled (2 Ls), so while both of these are correct it might be easy to confuse later.
| @@ -169,11 +187,12 @@ const ACTION_HANDLERS = { | |||
| [SET_MODALS]: (state, { modals }) => { | |||
| state.modals = modals | |||
| }, | |||
|
|
|||
| [SET_TOP_MODAL]: (state, { modal }) => { | |||
| state.modals[0] = modal | |||
There was a problem hiding this comment.
is it desired that we overwrite the topmost modal as opposed to shifting the queue ?
| <FormattedMessage {...messages.payment_request_keysend} /> | ||
| ) : ( | ||
| <QRCode value={paymentRequest.toUpperCase()} /> |
There was a problem hiding this comment.
Do we need to check for paymentRequest to be != null ? Looks like it's possible (isKeySend being false doesn't automatically mean that paymentRequest is set or does it?).
| </Text> | ||
| ) : ( | ||
| <Text color={getStatusColor()} fontWeight="light"> | ||
| <>{stateDisplayName}</> |
| @@ -123,10 +123,22 @@ const commitString = createSelector(version, v => { | |||
| return c ? c.replace('commit=', '') : undefined | |||
| }) | |||
|
|
|||
| /** | |||
| * hasRouterSupport - Check whether node has support for Invoices service | |||
There was a problem hiding this comment.
hasRouterSupport -> hasInvoicesSupport
| return ( | ||
| <Box> | ||
| <Flex alignItems="center" justifyContent="space-between"> | ||
| <Flex> |
There was a problem hiding this comment.
Any reason to have "double" <Flex> here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Motivation and Context:
Support more LN features
How Has This Been Tested?
Manually
Screenshots:
Types of changes:
Feature
Checklist: