Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

feature(eslint-resolve-paths-from-app-dir): use 'app' path as default… #40

Merged

Conversation

zobroj
Copy link
Contributor

@zobroj zobroj commented Sep 25, 2017

… for imports

get rid of those ../../../../../paths^^

@jackmallers
Copy link
Contributor

Nice! Do you wanna replace all annoying paths in this PR or merge the fix (in .eslintrc) and I can handle replacing all annoying paths later? @VonIobro

@zobroj
Copy link
Contributor Author

zobroj commented Sep 26, 2017

I can replace all the annoying paths in this PR. No problem.

@zobroj
Copy link
Contributor Author

zobroj commented Sep 26, 2017

The above commits have been tested and are ready to be merged. The paths for the .scss files have not been changed because of the problem below.

There seems to be a problem with webpack/css-loader/sass-loader not recognizing the resolved paths. While preparing to npm run test, npm run build-renderer fails when resolved-paths for scss imports:

 ERROR in ./node_modules/css-loader?{"modules":true,"importLoaders":1,"localIdentName":"[name]__[local]__[hash:base64:5]"}!./node_modules/sass-loader/lib/loader.js!./app/routes/wallet/components/Wallet.scss
    Module build failed: 
    @import 'variables.scss';
    ^
          File to import not found or unreadable: variables.scss.

I will look into this, but my forte is not in webpack nor scss (more of a styled-components, guy^^). So I may not be able to resolve this. @jackmallers should I just create an issue for this problem?

@jackmallers
Copy link
Contributor

Beautiful @VonIobro, nice first contribution! Yeah if you wanna create an issue we can take care of that issue at some point.

I actually don't mind styled components myself. One day when this project is in a much more stable place and goes through a large refactor we can make that switch

@jackmallers jackmallers merged commit 1160b64 into LN-Zap:master Sep 26, 2017
@thisconnect
Copy link

this is non standard esmodule path resolving correct? in case you want to use another builder this might not work anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants