Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(network): ensure accurate btc balance #712

Merged
merged 1 commit into from Aug 26, 2018
Merged

Conversation

JimmyMow
Copy link
Member

@JimmyMow JimmyMow commented Aug 25, 2018

We had satoshisToBtc hardcoded for our network (channel) balance. This updates it to use the Value component to ensure it displays correct balance depending on if the user is viewing in sats, bits or btc

@JimmyMow JimmyMow requested a review from mrfelton August 25, 2018 19:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3850

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.964%

Totals Coverage Status
Change from base Build 3837: 0.0%
Covered Lines: 571
Relevant Lines: 3417

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Aug 25, 2018

Pull Request Test Coverage Report for Build 3850

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.964%

Totals Coverage Status
Change from base Build 3837: 0.0%
Covered Lines: 571
Relevant Lines: 3417

💛 - Coveralls

Copy link
Member

@mrfelton mrfelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 9d53826

@mrfelton mrfelton merged commit 73d5b56 into master Aug 26, 2018
@mrfelton mrfelton deleted the fix/network-balance branch August 26, 2018 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants