Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(syncing): add space to bottom of sync page #716

Closed
wants to merge 1 commit into from

Conversation

JimmyMow
Copy link
Member

Fix for #666

@mrfelton
Copy link
Member

mrfelton commented Aug 26, 2018

@JimmyMow I actually fixed this already, in a slightly different way:

See #708

The problem really is that the actual display area is smaller on windows because you have the titlebar, and the menubar within the window itself, where as on mac this is not the case. The Electron useContentSize property addresses this specific issue.

@coveralls
Copy link

coveralls commented Aug 26, 2018

Pull Request Test Coverage Report for Build 3867

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 14.996%

Totals Coverage Status
Change from base Build 3859: -0.4%
Covered Lines: 571
Relevant Lines: 3407

💛 - Coveralls

@JimmyMow
Copy link
Member Author

@mrfelton ok this can be closed. i was just scrolling through the open issues looking for things to fix. let's close #666 then?

@mrfelton
Copy link
Member

Yes, I think so. I like this approach because it ensures that we have the exact same pixel height to work with on both platforms rather than leaving it up to guess work

@mrfelton
Copy link
Member

... I mean to merge the fix from #708 and close this one

@JimmyMow JimmyMow closed this Aug 26, 2018
@JimmyMow JimmyMow deleted the fix/syncing-spacing branch August 26, 2018 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants