-
Notifications
You must be signed in to change notification settings - Fork 215
fix(channels): closing channels link to closing_txid #720
Conversation
Pull Request Test Coverage Report for Build 3889
💛 - Coveralls |
@JimmyMow I closed out a channel, but the closing channel didn't seem to have a Below is the full state tree from whist the channel was still marked as closing in the UI. There is no
|
@mrfelton from the looks of the data above this is because your channel was in I do think the UX can be improved by differentiating between |
I'm not too sure what the difference is between My guess is that most users of the wallet wouldn't know the difference based on that terminology either, so if you can think of a way to visually make it more clear what state the transaction is in without confusing users I think it would be beneficial, although can go in a separate PR. In regards to my test - the channel has completely disappeared from the channels list now, and I never had a chance to see the link to the closing transaction at all. It must have shown for less than a minute as I was watching pretty closely! So... I'm not quite sure how I can test this. Any suggestions? |
@jackmallers it seems to me that it's not moving things from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 4eb140d
There is an issue in lnd where by the grpc stream gets an update with the TX id but it's not returned in the pendingchannels call, so we can't guarantee that we always have this information available. We could try to hack around it but the better thing to do would be to fix it directly in lnd. I'm going to merge this PR as an initial step towards this improvement. This can be further improved down the line by addressing the underlaying issue with lnd to ensure that we can also get the closing tx when fetching pending channels. |
We currently hard code our channel explorer links to the channel point (funding transaction). For closing channels this isn't really relevant and bad UX. This PR updates the logic for the explorer link: if the channel has a closing tx (it's in the process of being closed) then let's link to that, otherwise the funding tx is fine 👍