This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix(grpc): use Numbers to represent long values #728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure gRPC to use Numbers to represent long values instead of Strings. This ensures that we can do accurate handling of numerical values.
Description:
This ensures that numbers are actually numbers and not strings so a check like
if (val) { ... }
would will give expected results.For example:
but
(
"0"
is a truthy value, whilst0
is not)Motivation and Context:
Fix #727
Types of changes:
Bux fix
Checklist: